This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
CI: Don't move to Lightning Trainer / PL 1.7.0 (temporary fix) #1415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PL 1.7.0 broke the CI (~14 failures), partially because of BC changes and sometimes because of changes in PL 1.7.0. This blocks us from merging PRs, community contributions, and more.
Most of the failures have been fixed, but there are a couple of them remaining and are being addressed in #1410, and other relevant issues in the Lightning repository. We will go back to supporting PL's latest versions once issues are fixed. (partially addresses #1413)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
cc: @Borda @ethanwharris @carmocca (for visibility)