Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Upgrade @krshrimali to leads #1436

Merged
merged 6 commits into from
Aug 30, 2022
Merged

Upgrade @krshrimali to leads #1436

merged 6 commits into from
Aug 30, 2022

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Makes @krshrimali a lead

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the documentation Improvements or additions to documentation label Aug 30, 2022
@ethanwharris ethanwharris added this to the 0.8.0 milestone Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1436 (f49d014) into master (b83a208) will decrease coverage by 6.12%.
The diff coverage is n/a.

❗ Current head f49d014 differs from pull request most recent head 2488e9f. Consider uploading reports for the commit 2488e9f to get more accurate results

@@            Coverage Diff             @@
##           master    #1436      +/-   ##
==========================================
- Coverage   92.91%   86.79%   -6.13%     
==========================================
  Files         286      286              
  Lines       12874    12874              
==========================================
- Hits        11962    11174     -788     
- Misses        912     1700     +788     
Flag Coverage Δ
unittests 86.79% <ø> (-6.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lash/image/embedding/vissl/transforms/utilities.py 15.15% <0.00%> (-84.85%) ⬇️
flash/image/embedding/heads/vissl_heads.py 35.29% <0.00%> (-64.71%) ⬇️
flash/image/embedding/losses/vissl_losses.py 37.50% <0.00%> (-62.50%) ⬇️
flash/image/embedding/vissl/adapter.py 31.63% <0.00%> (-62.25%) ⬇️
flash/image/detection/input.py 38.88% <0.00%> (-61.12%) ⬇️
...age/face_detection/backbones/fastface_backbones.py 42.10% <0.00%> (-57.90%) ⬇️
flash/image/face_detection/model.py 36.84% <0.00%> (-55.27%) ⬇️
flash/image/face_detection/input_transform.py 46.87% <0.00%> (-53.13%) ⬇️
flash/image/face_detection/output_transform.py 47.05% <0.00%> (-52.95%) ⬇️
flash/image/detection/output.py 43.47% <0.00%> (-52.18%) ⬇️
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very special! Thank you so much, @ethanwharris and @Borda for being amazing mentors, and leaders. 🎉 It looks great to me 😄

@ethanwharris ethanwharris merged commit 0253d71 into master Aug 30, 2022
@ethanwharris ethanwharris deleted the feature/kush-lead branch August 30, 2022 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants