Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Docs/seo #190

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Docs/seo #190

merged 3 commits into from
Mar 24, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 24, 2021

What does this PR do?

fix canonical links in docs

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the documentation Improvements or additions to documentation label Mar 24, 2021
@Borda Borda enabled auto-merge (squash) March 24, 2021 07:51
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #190 (dcaf126) into master (03b8426) will decrease coverage by 6.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
- Coverage   87.03%   80.56%   -6.47%     
==========================================
  Files          49       49              
  Lines        1589     1590       +1     
==========================================
- Hits         1383     1281     -102     
- Misses        206      309     +103     
Flag Coverage Δ
unittests 80.56% <100.00%> (-6.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/__init__.py 100.00% <100.00%> (ø)
flash/vision/detection/data.py 26.27% <0.00%> (-67.80%) ⬇️
flash/vision/detection/finetuning.py 62.50% <0.00%> (-37.50%) ⬇️
flash/vision/detection/model.py 63.01% <0.00%> (-10.96%) ⬇️
flash/text/seq2seq/core/data.py 79.45% <0.00%> (-5.48%) ⬇️
flash/core/trainer.py 82.50% <0.00%> (-5.00%) ⬇️
flash/core/data/datapipeline.py 96.55% <0.00%> (-3.45%) ⬇️
flash/core/data/datamodule.py 97.77% <0.00%> (-2.23%) ⬇️
flash/vision/classification/data.py 83.33% <0.00%> (-2.00%) ⬇️
flash/vision/backbones.py 91.93% <0.00%> (-1.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03b8426...dcaf126. Read the comment docs.

@Borda Borda disabled auto-merge March 24, 2021 07:55
@Borda Borda merged commit b918adb into master Mar 24, 2021
@Borda Borda deleted the docs/seo branch March 24, 2021 07:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant