This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 212
[feat] Add support for running_stage and current_fn in all Preprocess hook (1 / 2) #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
Borda,
carmocca,
justusschock,
kaushikb11 and
teddykoker
as code owners
March 31, 2021 17:23
tchaton
changed the title
[feat] Add support for running_stage and current_fn in all Preprocess hook
[feat] Add support for running_stage and current_fn in all Preprocess hook (1 / 2)
Mar 31, 2021
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 85.11% 85.70% +0.59%
==========================================
Files 54 54
Lines 2391 2483 +92
==========================================
+ Hits 2035 2128 +93
+ Misses 356 355 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kaushikb11
reviewed
Apr 1, 2021
edgarriba
reviewed
Apr 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions for typing, few comments and open questions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes each Preprocess hook aware of its current function name and running_state.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃