Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix translation #332

Merged
merged 9 commits into from
May 28, 2021
Merged

Fix translation #332

merged 9 commits into from
May 28, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented May 21, 2021

What does this PR do?

Fixes #334
Related to #310

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #332 (b4bfa31) into master (ae6801f) will increase coverage by 0.21%.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   88.61%   88.82%   +0.21%     
==========================================
  Files          80       80              
  Lines        4066     4143      +77     
==========================================
+ Hits         3603     3680      +77     
  Misses        463      463              
Flag Coverage Δ
gpu ?
pytest ?
unittests 88.82% <94.59%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/seq2seq/translation/model.py 70.00% <0.00%> (-3.69%) ⬇️
flash/text/seq2seq/core/data.py 87.33% <94.11%> (+5.19%) ⬆️
flash/text/classification/data.py 88.32% <100.00%> (+4.16%) ⬆️
flash/text/seq2seq/summarization/data.py 100.00% <100.00%> (+12.90%) ⬆️
flash/text/seq2seq/translation/data.py 100.00% <100.00%> (ø)
flash/text/seq2seq/translation/metric.py 97.95% <100.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6801f...b4bfa31. Read the comment docs.

@akihironitta akihironitta added the bug / fix Something isn't working label May 23, 2021
@ethanwharris ethanwharris marked this pull request as ready for review May 28, 2021 15:42
@ethanwharris ethanwharris merged commit 1054949 into master May 28, 2021
@ethanwharris ethanwharris deleted the bugfix/seq2seq branch May 28, 2021 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading pretrained translation model fails due to Not found: "/Users/ethan/..."
3 participants