-
Notifications
You must be signed in to change notification settings - Fork 212
[RFC] Change installation for extra packages #346
Conversation
@tchaton @Borda @ethanwharris I'd love to know your thoughts on this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akihironitta This looks great 😃 definitely more intuitive than before
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 80 80
Lines 4143 4143
=======================================
Hits 3680 3680
Misses 463 463
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just be aware that this will install only packages from pypi, no with given path/url
@Borda not sure about urls but afaik you can definitely do you just need the quotation marks :) |
What does this PR do?
We recently divided requirements into several wrt data types (e.g.
pip install lightning-flash[image]
), but I don't think it's intuitive to users as I left a comment in #215 (comment).TODO
I'll update the docs and fix failing CI (if there is) once I get positive comments from core members.
Description of the changes
Before
After
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃