Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix summarization #372

Merged
merged 6 commits into from
Jun 7, 2021
Merged

Fix summarization #372

merged 6 commits into from
Jun 7, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Jun 7, 2021

What does this PR do?

Fixes #310

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jun 7, 2021

Hello @ethanwharris! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-07 14:01:22 UTC

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #372 (23adc4a) into master (7f8c3e8) will increase coverage by 0.01%.
The diff coverage is 71.42%.

❗ Current head 23adc4a differs from pull request most recent head 3f52680. Consider uploading reports for the commit 3f52680 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
+ Coverage   88.79%   88.80%   +0.01%     
==========================================
  Files          80       80              
  Lines        4176     4180       +4     
==========================================
+ Hits         3708     3712       +4     
  Misses        468      468              
Flag Coverage Δ
unittests 88.80% <71.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/seq2seq/summarization/model.py 73.68% <0.00%> (ø)
flash/text/seq2seq/summarization/data.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f8c3e8...3f52680. Read the comment docs.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! nice work !

@ethanwharris ethanwharris merged commit bded76d into master Jun 7, 2021
@ethanwharris ethanwharris deleted the bugfix/summarization branch June 7, 2021 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task doesn't seem to converge: Summurization, Translation
4 participants