-
Notifications
You must be signed in to change notification settings - Fork 212
Adding optional sampler input to DataModule #390
Adding optional sampler input to DataModule #390
Conversation
Could someone supply me with info on how I should add this to the |
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
==========================================
- Coverage 89.79% 83.40% -6.39%
==========================================
Files 80 80
Lines 4203 4207 +4
==========================================
- Hits 3774 3509 -265
- Misses 429 698 +269
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lillekemiker Awesome! LGTM. Regarding the CHANGELOG, could you just add a line under Added
in the Unreleased
section at the top, no need for a version bump 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just small suggestion
What does this PR do?
This PR adds the option of specifying a sampler to be used in the training
DataLoader
returned by aDataModule
.Fixes # 350
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃