Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

fix docs #58

Merged
merged 8 commits into from
Feb 2, 2021
Merged

fix docs #58

merged 8 commits into from
Feb 2, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 2, 2021

What does this PR do?

some link fixing and tests

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the documentation Improvements or additions to documentation label Feb 2, 2021
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #58 (bb2aa67) into master (27f765d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   80.31%   80.31%           
=======================================
  Files          47       47           
  Lines        1387     1387           
=======================================
  Hits         1114     1114           
  Misses        273      273           
Flag Coverage Δ
unittests 80.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f765d...3568c60. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Feb 2, 2021

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-02 23:35:38 UTC

@Borda Borda marked this pull request as ready for review February 2, 2021 21:33
@Borda Borda enabled auto-merge (squash) February 2, 2021 21:48
docs/source/conf.py Outdated Show resolved Hide resolved
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Copy link
Contributor

@teddykoker teddykoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Borda Borda merged commit c6725fe into master Feb 2, 2021
@Borda Borda deleted the docs/tests branch February 2, 2021 23:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants