Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

examples: set gpus=device_count #638

Merged
merged 10 commits into from
Aug 16, 2021
Merged

examples: set gpus=device_count #638

merged 10 commits into from
Aug 16, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 6, 2021

What does this PR do?

use all GPUs if possible

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the documentation Improvements or additions to documentation label Aug 6, 2021
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #638 (0be14c6) into master (f733c26) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files         173      173           
  Lines        9232     9232           
=======================================
  Hits         8363     8363           
  Misses        869      869           
Flag Coverage Δ
unittests 90.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f733c26...0be14c6. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Aug 6, 2021

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-06 12:06:48 UTC

@ethanwharris ethanwharris changed the title examples: set gpus=-1 examples: set gpus=device_count Aug 6, 2021
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😃 Why the change in semantic segmentation prediction?

flash_examples/semantic_segmentation.py Outdated Show resolved Hide resolved
Borda and others added 3 commits August 6, 2021 14:06
@Borda Borda requested a review from ethanwharris August 15, 2021 21:51
@ethanwharris ethanwharris enabled auto-merge (squash) August 16, 2021 15:14
@ethanwharris ethanwharris merged commit 2e3c891 into master Aug 16, 2021
@ethanwharris ethanwharris deleted the examples/gpus branch August 16, 2021 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants