Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Drop broken sphinx docs build #661

Merged
merged 22 commits into from
Aug 16, 2021
Merged

Drop broken sphinx docs build #661

merged 22 commits into from
Aug 16, 2021

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Aug 16, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #661 (97ef36f) into master (b766cc3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #661   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files         173      173           
  Lines        9232     9232           
=======================================
  Hits         8363     8363           
  Misses        869      869           
Flag Coverage Δ
unittests 90.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b766cc3...97ef36f. Read the comment docs.

@ethanwharris ethanwharris changed the title Try to debug docs build Drop broken sphinx docs build Aug 16, 2021
@ethanwharris ethanwharris marked this pull request as ready for review August 16, 2021 14:51
@ethanwharris ethanwharris requested a review from Borda as a code owner August 16, 2021 14:51
@Borda Borda added tests / CI Tests and continuous integration documentation Improvements or additions to documentation labels Aug 16, 2021
@mergify mergify bot requested a review from a team August 16, 2021 14:52
@ethanwharris ethanwharris merged commit f733c26 into master Aug 16, 2021
@ethanwharris ethanwharris deleted the bugfix/docs_build branch August 16, 2021 15:13
@Borda Borda added bug / fix Something isn't working refactors & code health labels May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working documentation Improvements or additions to documentation refactors & code health tests / CI Tests and continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants