Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Onboard IceVision inputs to new object #973

Merged
merged 8 commits into from
Nov 17, 2021
Merged

Conversation

ethanwharris
Copy link
Collaborator

@ethanwharris ethanwharris commented Nov 16, 2021

What does this PR do?

Part of #961

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #973 (10af852) into master (41d97b5) will decrease coverage by 0.06%.
The diff coverage is 66.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
- Coverage   88.33%   88.26%   -0.07%     
==========================================
  Files         250      250              
  Lines       13120    13155      +35     
==========================================
+ Hits        11589    11611      +22     
- Misses       1531     1544      +13     
Flag Coverage Δ
unittests 88.26% <66.05%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/utilities/paths.py 35.55% <23.68%> (+2.22%) ⬆️
flash/image/instance_segmentation/data.py 91.11% <81.81%> (+1.11%) ⬆️
flash/image/detection/data.py 93.85% <88.46%> (+0.10%) ⬆️
flash/image/keypoint_detection/data.py 91.42% <90.00%> (+1.42%) ⬆️
flash/core/integrations/icevision/data.py 93.02% <90.47%> (+6.74%) ⬆️
flash/image/detection/cli.py 100.00% <100.00%> (ø)
flash/image/instance_segmentation/cli.py 100.00% <100.00%> (ø)
flash/image/keypoint_detection/cli.py 100.00% <100.00%> (ø)
flash/core/integrations/fiftyone/utils.py 59.18% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d97b5...10af852. Read the comment docs.

@ethanwharris ethanwharris changed the title [WIP] Onboard IceVision inputs to new object Onboard IceVision inputs to new object Nov 17, 2021
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, happy with the changes your making as discussed offline :)

@ethanwharris ethanwharris merged commit 073166e into master Nov 17, 2021
@ethanwharris ethanwharris deleted the feature/icevision_inputs branch November 17, 2021 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants