[FEATURE] Add encryption #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
settings.ini
Outdated
| @@ -13,17 +13,17 @@ maxpendingchannels = 5 | |||
|
|
|||
| [bitcoin] | |||
| active = true | |||
| node = neutrino | |||
| network = mainnet | |||
| node = btcd | |||
| @@ -19,14 +23,28 @@ const types = { | |||
| SOCKET_UNAUTHORIZED_CONNECTION: "UNAUTHORIZED_CONNECTION", | |||
| SOCKET_SIGN_MESSAGE_SUCCESS: "SIGN_MESSAGE_SUCCESS", | |||
| SOCKET_ADD_INVOICE_REMOTE_RESPONSE: "ADD_INVOICE_REMOTE_RESPONSE", | |||
| SOCKET_ADD_INVOICE_ENCRYPTED_REMOTE_RESPONSE: "ADD_INVOICE_ENCRYPTED_REMOTE_RESPONSE", | |||
| SOCKET_ADD_INVOICE_REMOTE_REQUEST: "ADD_INVOICE_REMOTE_REQUEST", | |||
There was a problem hiding this comment.
Duplicate with line 17
| invoiceResponse[key] = null; | ||
| const id = `${Date.now()}${crypto.randomBytes(5).toString("hex")}`; | ||
|
|
||
| // const defParams = { |
|
retest this please |
|
retest this please |
|
retest this please |
1 similar comment
|
retest this please |
serhiislobodian
approved these changes
Mar 25, 2019
| // timout for saving shared keys - 1 hour | ||
| const KEY_SAVE_TIMEOUT = 60 * 60 * 1000; | ||
| // local storage for shared keys | ||
| // let keyStorage = {}; |
There was a problem hiding this comment.
Something left from dev
| const pubkey = ec.keyFromPublic(msg.data.pubkey, "hex"); | ||
| // remember shared key for particular id | ||
|
|
||
| // for test |
There was a problem hiding this comment.
Left from testing/dev or necessary part?
| break; | ||
| } | ||
| case types.SOCKET_PUBKEY_RESPONSE: { | ||
| logger.debug("Will check auth", invoiceStorage[msg.data.id]); |
There was a problem hiding this comment.
Cleanup logger, remove unnecessary, duplicated(for comments too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add encryption for socket messages for invoice (compatible for receive from an old version of wallet, but cannot send to an old version of wallet)