Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behavior for placeholder attribute #17

Closed
kasparsklavins opened this issue Nov 8, 2017 · 3 comments
Closed

Change behavior for placeholder attribute #17

kasparsklavins opened this issue Nov 8, 2017 · 3 comments

Comments

@kasparsklavins
Copy link

kasparsklavins commented Nov 8, 2017

From README.md:

If the attribute placeholder of attr is provided [...] It will be extracted as the default option.

According to html5 spec[0], placeholders are meant as hints for the input, and may contain a non-valid value

The placeholder attribute represents a short hint (a word or short phrase) intended to aid the user with data entry. A hint could be a sample value or a brief description of the expected format

I propose removing the feature of using placeholder attribute for a default value.

[0] https://www.w3.org/TR/2011/WD-html5-20110405/common-input-element-attributes.html#the-placeholder-attribute

@nacmartin
Copy link
Member

Uhm, yes, I think that this is right. Pass it as an extra attribute out of the specification would be better so the client can use it or not.

@kasparsklavins
Copy link
Author

I can do a PR for this.
Is there any contributing policy?

@nacmartin
Copy link
Member

Oh, thanks! Not really. It would be nice to add a test, though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants