Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send, sendto, recv, recvfrom syscall comments and tests #314

Merged
merged 14 commits into from
Aug 15, 2024

Conversation

davidge20
Copy link
Contributor

@davidge20 davidge20 commented Jul 18, 2024

Description

Commented send, sendto, recv, recvfrom syscalls.
Added basic tests to flag errors in send and ran exhaustive tests on unix sockets for sends/receives

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A - `ut_lind_net_recvfrom_unix()
  • Test B - 'ut_lind_net_send_close_server_socket_early()'
  • Test C - 'ut_lind_net_send_no_peer_address()'

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, lind-project)

src/safeposix/syscalls/net_calls.rs Outdated Show resolved Hide resolved
src/safeposix/syscalls/net_calls.rs Outdated Show resolved Hide resolved
src/safeposix/syscalls/net_calls.rs Show resolved Hide resolved
src/safeposix/syscalls/net_calls.rs Outdated Show resolved Hide resolved
src/safeposix/syscalls/net_calls.rs Show resolved Hide resolved
src/safeposix/syscalls/net_calls.rs Outdated Show resolved Hide resolved
src/safeposix/syscalls/net_calls.rs Outdated Show resolved Hide resolved
src/safeposix/syscalls/net_calls.rs Outdated Show resolved Hide resolved
@rennergade rennergade requested a review from ve1nard July 19, 2024 15:07
Copy link
Contributor

@ve1nard ve1nard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small question

src/safeposix/syscalls/net_calls.rs Show resolved Hide resolved
Copy link
Contributor

@ve1nard ve1nard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@yashaswi2000 yashaswi2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some questions for clarification

@qianxichen233 qianxichen233 self-requested a review July 25, 2024 03:16
Copy link
Contributor

@yashaswi2000 yashaswi2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/safeposix/syscalls/net_calls.rs Outdated Show resolved Hide resolved
src/safeposix/syscalls/net_calls.rs Show resolved Hide resolved
src/safeposix/syscalls/net_calls.rs Outdated Show resolved Hide resolved
src/safeposix/syscalls/net_calls.rs Show resolved Hide resolved
src/safeposix/syscalls/net_calls.rs Outdated Show resolved Hide resolved
src/safeposix/syscalls/net_calls.rs Outdated Show resolved Hide resolved
src/safeposix/syscalls/net_calls.rs Outdated Show resolved Hide resolved
src/safeposix/syscalls/net_calls.rs Show resolved Hide resolved
src/tests/networking_tests.rs Show resolved Hide resolved
@rennergade
Copy link
Contributor

@JustinCappos can you give David feedback so we can finalize this?

@rennergade rennergade merged commit 3d13034 into develop Aug 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants