Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the sync behavior to fit the LTFS format Spec 2.5 #461

Merged
merged 2 commits into from
May 24, 2024

Conversation

piste-jp
Copy link
Member

Summary of changes

In the LTFS format spec 2.5, behavior of sync is changed.

  • Sync index when ltfs.commitMessage is written
  • Sync index with a written message as a commit message via ltfs.sync

Description

The changes in this PR make commit massage more specific. It means specified message is always written down to the tape. So there is no need to take care about carry over of the message.

In this PR, I made the changes below.

  1. commit message is always specified implicitly or explicitly
  2. In the implicit case, like periodic, unmount etc., the message is automatically generated based on the reason of sync

Fixes #455

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have confirmed my fix is effective or that my feature works<

Atsushi Abe added 2 commits May 23, 2024 11:15
  - Sync when ltfs.commitMessage or ltfs.sync is written with an UTF-8 string
  - Overwrite commit message when index is written because of predefined reasons
  - Sync with a predefined reason when ltfs.commitMessage or ltfs.sync
    receive an normalized UTF-8 string
@piste-jp piste-jp requested a review from jgreen24 May 23, 2024 02:18
@piste-jp piste-jp self-assigned this May 23, 2024
@piste-jp piste-jp merged commit 06367df into LinearTapeFileSystem:master May 24, 2024
10 checks passed
@piste-jp piste-jp deleted the new_sync branch May 24, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FS2.5: Need to change behavior of a few VEAs
1 participant