Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement MRCA function #490

Closed
EvaLiyt opened this issue Jun 5, 2024 · 2 comments
Closed

implement MRCA function #490

EvaLiyt opened this issue Jun 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@EvaLiyt
Copy link
Collaborator

EvaLiyt commented Jun 5, 2024

The deterministic function looks for the most recent common ancestor of a given tree and given taxa names.
@EvaLiyt EvaLiyt added the enhancement New feature or request label Jun 5, 2024
EvaLiyt added a commit that referenced this issue Jun 5, 2024
@EvaLiyt
implement MRCA function #490
c38154e
@alexeid
Copy link
Collaborator

alexeid commented Jun 5, 2024

Is this a method of TimeTree? If not, should it be?

@kche309
Copy link
Collaborator

kche309 commented Jun 5, 2024 •
edited
Loading

It is not currently a method of TimeTree.

We discussed two options for adding mrca, either as a function mrca(tree, taxa) or as a method of TimeTree tree.mrca(taxa)

EvaLiyt added a commit that referenced this issue Jun 10, 2024
@EvaLiyt
register mrca function #490
bdb681f
yxu927 added a commit that referenced this issue Jun 14, 2024
@yxu927
implement MRCA function #490 #496
d075c49
yxu927 added a commit that referenced this issue Jun 14, 2024
@yxu927
register mrca function #490 #496
0d90c3c
@EvaLiyt EvaLiyt closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexeid @kche309 @EvaLiyt