Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let PhyloCTMC use branch rates from tree if not given #491

Closed
EvaLiyt opened this issue Jun 5, 2024 · 3 comments
Closed

let PhyloCTMC use branch rates from tree if not given #491

EvaLiyt opened this issue Jun 5, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@EvaLiyt
Copy link
Collaborator

EvaLiyt commented Jun 5, 2024

Make branchRates an optional parameter. If branchRates are given, then consider it a relaxed clock. If branchRates are not given and the tree has its own branch rates, then consider it a local clock. Otherwise, consider it a strict clock with a rate of 1.0.

@EvaLiyt EvaLiyt added the enhancement New feature or request label Jun 5, 2024
@alexeid
Copy link
Collaborator

alexeid commented Jun 5, 2024

In what sense do you "consider it a local clock"? Do the branch rates in the tree just get used to generate the alignment, regardless of how they were generated?

@kche309
Copy link
Collaborator

kche309 commented Jun 6, 2024

The branch rates on the tree metadata are used to generate the alignment when the branchRates input is not given explicitly.
@alexeid I think what she means is that in the current code only the "local clock" and "subsampleTree" generate branch rate metadata on the tree.

@kche309
Copy link
Collaborator

kche309 commented Jun 6, 2024

There is no assumption that the branch rates metadata of a tree must be from a local clock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants