Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate reso in convert_datetime_index, fixup fixture; #332

Conversation

MarcoGorelli
Copy link

closes LinkedEarth/paleoPandas#31

numbers look a bit more reasonable now :)

@MarcoGorelli MarcoGorelli force-pushed the check-reso-in-convert-datetime-index branch from 545eaf3 to ea3efc5 Compare February 16, 2023 20:03
Copy link
Collaborator

@CommonClimate CommonClimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the check to s resolution. Hopefully this is the only place in the code where we need it? What about from_pandas()?

@MarcoGorelli
Copy link
Author

that's a good point - I checked and from_pandas calls this method anyway, so I don't think it would be needed there too (can add if you prefer though)

@CommonClimate CommonClimate merged commit 5ede8e8 into LinkedEarth:Development Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants