add remove and __sub__ methods #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommonClimate
approved these changes
Feb 21, 2023
|
Hi @MarcoGorelli , this looks good. Small point of detail: in the "add" PR you defined a TestOverload class where you test "add", but the "sub" method is tested under TestRemove. Not a big deal as long as the tests are working, but maybe more logical to bundle the overload methods together? |
|
(sorry, I only noticed this after approving, resolving conflicts, and merging) |
|
thanks for updating! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes LinkedEarth/paleoPandas#17