Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update environment, use new env in ci #343

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

kcpevey
Copy link
Contributor

@kcpevey kcpevey commented Feb 22, 2023

While I was working on other things, I did a little testing of the environment on the side. I know that the environment.yml has a specific usage outside of this package so I've created a new env (environment.yml).

This contains all the required packages to run pyleoclim (as found by depfinder. One question I had was this LiPD package, but since it couldn't be installed into an environment, I suspect its not being used.

I've also added this environment to CI since it explicitly contains all requirements. If we had 100% test coverage, the env we currently use in CI would not be sufficient.

While I was adding it to CI, I realized that because the github action wasn't installing the checked out branch and was instead relying on the environment file, I think we've just been running tests on the Development branch, not the PRs 😵 This fixes that.

Comment on lines +30 to +31
- "--pre --extra-index https://pypi.anaconda.org/scipy-wheels-nightly/simple"
- pandas>=1.9

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pandas now has a 2.0 release candidate 🎉 might be easier to use that?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessarily relevant to this PR, this was just FYI

@khider
Copy link
Member

khider commented Feb 22, 2023

Yes, we still need this package. And the version is fixed in the setup.py requirements.

@CommonClimate
Copy link
Collaborator

Hi @kcpevey , good idea. BTW, this is no exactly true anymore:

I know that the environment.yml has a specific usage outside of this package
We are very much trying for this environment to just contain what we need to run and use the package minimally. We're building separate a environment for our JupyterHub. So once you figure out this one (hopefully with pandas 2.0), it should become our default.

@CommonClimate
Copy link
Collaborator

@khider I'm going to let you review and approve, as you have more (informed) opinions about this than I do.

@khider khider merged commit 3290843 into LinkedEarth:Development Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants