Update environment, use new env in ci #343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was working on other things, I did a little testing of the environment on the side. I know that the
environment.yml
has a specific usage outside of this package so I've created a new env (environment.yml
).This contains all the required packages to run pyleoclim (as found by
depfinder
. One question I had was this LiPD package, but since it couldn't be installed into an environment, I suspect its not being used.I've also added this environment to CI since it explicitly contains all requirements. If we had 100% test coverage, the env we currently use in CI would not be sufficient.
While I was adding it to CI, I realized that because the github action wasn't installing the checked out branch and was instead relying on the environment file, I think we've just been running tests on the Development branch, not the PRs 😵 This fixes that.