Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use_common_time argument to MultipleSeries.to_pandas #350

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

MarcoGorelli
Copy link

No description provided.

Copy link
Collaborator

@CommonClimate CommonClimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that is a lot simpler than I thought! So, the alignment to a common index happens automatically when a dataframe is created? That works well. I think the default value for use_common_time should be False, so I made the change.

@CommonClimate
Copy link
Collaborator

So, right now the function call is to_pandas(self, *args, use_common_time=False, **kwargs). I am not exactly clear why *args is coming before use_common_time, and the order matters. Can you explain?

@MarcoGorelli
Copy link
Author

Hey - sure, it's just that in Python, you need to put positional arguments before keyword arguments. use_common_time is probably better as a keyword argument, so that's why I put it after *args

@khider
Copy link
Member

khider commented Mar 1, 2023

Should I merge this?

@CommonClimate
Copy link
Collaborator

CommonClimate commented Mar 1, 2023 via email

@khider khider merged commit cc1cd84 into LinkedEarth:Development Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants