Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe fix #398

Merged
merged 5 commits into from
Apr 26, 2023
Merged

Stripe fix #398

merged 5 commits into from
Apr 26, 2023

Conversation

CommonClimate
Copy link
Collaborator

@khider since you had reported the issue, you have the honor of reviewing the PR. I've redesigned the code so it utilizes MPL's pcolormesh under the hood, which has the added benefit of allowing for multiple colormaps (see docstring for examples).

import pyleoclim as pyleo
nino3 = pyleo.utils.load_dataset('NINO3')
fig, ax = nino3.stripes(show_xaxis=True)

generates:
nino3_stripes

while for MultipleSeries, this:

import pyleoclim as pyleo
co2ts = pyleo.utils.load_dataset('AACO2')
lr04 = pyleo.utils.load_dataset('LR04')
edc = pyleo.utils.load_dataset('EDC-dD')
ms = lr04.flip() & edc & co2ts # create MS object
fig, ax = ms.stripes(figsize=(8,2.5),show_xaxis=True, sat = 0.8)

generates that:
last800ka_stripes

I have tried to rely on the plotting.py function and make it as general as possible, but it might not be perfect. I need to move on to geoSeries, so this will have to do. It looks like it fixes bug #281 , which is what matters here.

show_xaxis still needs repair
+ typo fix in PSD.signif_test user msg
@CommonClimate CommonClimate requested review from alexkjames and removed request for khider and alexkjames April 26, 2023 17:42
@CommonClimate CommonClimate merged commit 5315080 into master Apr 26, 2023
@CommonClimate CommonClimate deleted the stripe_fix branch April 26, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

1 participant