Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensemblegeoseries + MCPCA #542

Merged
merged 30 commits into from
May 14, 2024
Merged

Ensemblegeoseries + MCPCA #542

merged 30 commits into from
May 14, 2024

Conversation

alexkjames
Copy link
Contributor

Adds several new objects to faciliate MCPCA analysis on age uncertain paleo records.

New class include:

  • EnsembleGeoSeries - An EnsembleSeries object for GeoSeries objects
  • MulEnsGeoSeries - An object to contain multiple EnsembleGeoSeries objects
  • MulMultivarDecomp - An object to store and plot the output of MCPCA applied to MulEnsGeoSeries objects

Contains unit tests for all new functions. Also includes a dashboard method for EnsembleGeoSeries objects, and several useful classmethods for generating ensemble and ensemblegeoseries objects from age arrays.

@alexkjames alexkjames requested a review from khider May 13, 2024 19:55
Copy link
Member

@khider khider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to have some example on how to create the object, especially for the classmethod portion

@CommonClimate
Copy link
Collaborator

Also, I thought we had agreed on MulMultivarDecomp being `EnsMultivarDecomp', since it's the ensemble part that we emphasize, and Multivar is already Mul. Wow, that was a mouthful...

@alexkjames
Copy link
Contributor Author

alexkjames commented May 14, 2024

Also, I thought we had agreed on MulMultivarDecomp being `EnsMultivarDecomp', since it's the ensemble part that we emphasize, and Multivar is already Mul. Wow, that was a mouthful...

You're right, I left my post it where I wrote that down in the office and, since I haven't been back since we had that meeting, just winged it. I updated the class name in the most recent commit above this comment (d8fa599).

@CommonClimate
Copy link
Collaborator

Great, thank you!

@khider khider merged commit 49a5088 into master May 14, 2024
1 check passed
@khider khider deleted the ensemblegeoseries branch May 14, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants