Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MulEnsGeoSeries stackplot #599

Merged
merged 10 commits into from
Jul 16, 2024
Merged

MulEnsGeoSeries stackplot #599

merged 10 commits into from
Jul 16, 2024

Conversation

alexkjames
Copy link
Contributor

Adds stackplot functionality to MulEnsGeoSeries class, alongside unit tests. Addresses #579

@alexkjames alexkjames requested a review from CommonClimate July 12, 2024 22:34
@alexkjames alexkjames self-assigned this Jul 12, 2024
Copy link
Collaborator

@CommonClimate CommonClimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexkjames, thanks for doing this.
I only tested the docstring example, which is fine, though it doesn't show much about how to customize the plot. Maybe refer to MultipleSeries.stackplot() in the "See Also" section so interested users can see how it's done?

@alexkjames alexkjames requested a review from CommonClimate July 15, 2024 18:44
@CommonClimate
Copy link
Collaborator

I like the new style feature. Can you make sure users can pass ensemble plot options as they would to EnsembleSeries.plot()? In particular, some users will want to adjust shade_alpha for plot_envelope() and num_traces for plot_traces()

@alexkjames
Copy link
Contributor Author

alexkjames commented Jul 15, 2024

I like the new style feature. Can you make sure users can pass ensemble plot options as they would to EnsembleSeries.plot()? In particular, some users will want to adjust shade_alpha for plot_envelope() and num_traces for plot_traces()

These are currently adjustable via the plot_kwargs option. I'm a bit hesitant to include exposed arguments for the plotting methods, since there usage will depend on what style is set to. I've include a docstring example of using the plot_kwargs argument to make these adjustments. Will that suffice? Or would you still like certain arguments to be exposed?

Copy link
Collaborator

@CommonClimate CommonClimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Good to go!

@alexkjames alexkjames merged commit 75fc911 into master Jul 16, 2024
1 check passed
@alexkjames alexkjames deleted the megs_stackplot branch July 16, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants