New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not load a default Pyleoclim style on init #632

Merged

CommonClimate merged 1 commit into master from style

Jan 9, 2025

Member

khider commented Jan 7, 2025

This pull request is in response to #615 . This was a user request by email who wanted to be able to use the default adaptive style of matplotlib.

The solution is to not load a style on init of the package.

PROS:

Able to use matplotlib default style
Does not impose a course of action on the user.

CONS:

If wanting to use the Pyleoclim styles, will need to be explicitly define at the top of a script/notebook (including our tutorials).

Other alternative considered:

Have the user change the style back to matplotlib. Unfortunately, this result in a non-adaptive plot. Here is the difference on the Cenogrid data.

Pyleoclim style
When style is changed to matplotlib
When no style is set by default in the Pyleoclim package (this pull request); therefore using matplotlib adaptive library


          Update __init__.py

khider requested a review from CommonClimate

January 7, 2025 20:41

CommonClimate approved these changes

View reviewed changes

CommonClimate merged commit cde9f2b into master

1 check passed

CommonClimate deleted the style branch

January 9, 2025 02:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet