Merge pull request #104 from sethkinast/coerce-false

Coerce falsy values when a type is specified by a comparison helper.
LinkedInAttic · Nov 20, 2014 · 91ec158 · 91ec158
2 parents 35bf5eb + 856d628
commit 91ec158
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/lib/dust-helpers.js b/lib/dust-helpers.js
@@ -70,14 +70,13 @@ function filter(chunk, context, bodies, params, filterOp) {
 }
 
 function coerce (value, type, context) {
-  if (value) {
-    switch (type || typeof(value)) {
+  if (typeof value !== "undefined") {
+    switch (type || typeof value) {
       case 'number': return +value;
       case 'string': return String(value);
-      case 'boolean': {
+      case 'boolean':
         value = (value === 'false' ? false : value);
         return Boolean(value);
-      }
       case 'date': return new Date(value);
       case 'context': return context.get(value);
     }

diff --git a/test/jasmine-test/spec/helpersTests.js b/test/jasmine-test/spec/helpersTests.js
@@ -537,6 +537,13 @@
          expected: "",
          message: "eq helper non equal boolean case"
       },
+      {
+         name:     "eq helper coerce falsy case",
+         source:   "{@eq key=x value=\"0\" type=\"string\"}equal{/eq}",
+         context:  {x:0},
+         expected: "equal",
+         message: "eq helper should coerce falsy booleans"
+      },
       {
         name:     "eq helper without a body",
         source:   "{@eq key=\"abc\" value=\"java\"/}",