-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @if and @idx #110
Remove @if and @idx #110
Conversation
Also, there's no dustjs 2.6 yet, so we can't actually cut a 1.6. |
So I've been doing upstream tracking wrong this whole time... derp. Fixed now. I don't know how best to announce this change. It's pretty major and i doubt anyone is going to RTFM before they update. The deprecation warnings are there but logging is off by default. |
It's made easier by the fact that no version of Dust exists that supports On Thu, Jan 15, 2015 at 8:45 AM, jimmyhchan notifications@github.com
Seth Kinast |
Throw the deprecation warning in the github wiki for now. This lgtm, will pull in when Seth or anyone else gives the go ahead. |
Squash looks good; don't pull it in though until we're ready to cut a 1.6. If you pull it in now we can't release a 1.5.x without cherrypicking. |
I love how this breaking change came out in a minor version bump. |
As has always been the case, Dust versioning follows different semantics than semver (this likely will change for Dust@3) Minor versions of Dust can change or remove functionality after deprecating the functionality for one full minor release. Patch releases of Dust and helpers always maintain compatibility. We recommend using These two helpers were present in helpers 1.4.0, deprecated (with messages) in 1.5.0, and removed in 1.6.0. |
closes #95. Following up with #102 where the
idx
and theif
helpers were deprecated, this pull request finally removes these helpers.With all the other helpers coming in,
if
is just unnecessary. This is breaks back compat so a 1.6.X branch is desirable.