Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @if and @idx #110

Merged
merged 2 commits into from
Mar 4, 2015
Merged

Remove @if and @idx #110

merged 2 commits into from
Mar 4, 2015

Conversation

jimmyhchan
Copy link
Contributor

closes #95. Following up with #102 where the idx and the if helpers were deprecated, this pull request finally removes these helpers.

With all the other helpers coming in, if is just unnecessary. This is breaks back compat so a 1.6.X branch is desirable.

@sethkinast
Copy link
Contributor

You have some weird commits in the PR, squash?

Is there anything else we should do before cutting a 1.6? At a minimum I'd like to get #108, #109 in.

@sethkinast
Copy link
Contributor

Also, there's no dustjs 2.6 yet, so we can't actually cut a 1.6.

@jimmyhchan
Copy link
Contributor Author

So I've been doing upstream tracking wrong this whole time... derp. Fixed now.

I don't know how best to announce this change. It's pretty major and i doubt anyone is going to RTFM before they update. The deprecation warnings are there but logging is off by default.

@sethkinast
Copy link
Contributor

It's made easier by the fact that no version of Dust exists that supports
1.6 yet anyways so we can tell people twice :P

On Thu, Jan 15, 2015 at 8:45 AM, jimmyhchan notifications@github.com
wrote:

So I've been doing upstream tracking wrong this whole time... derp. Fixed
now.

I don't know how best to announce this change. It's pretty major and i
doubt anyone is going to RTFM before they update. The deprecation warnings
are there but logging is off by default.


Reply to this email directly or view it on GitHub
#110 (comment)
.

Seth Kinast
http://sethkinast.com/

@prashn64
Copy link
Contributor

Throw the deprecation warning in the github wiki for now. This lgtm, will pull in when Seth or anyone else gives the go ahead.

@sethkinast
Copy link
Contributor

Squash looks good; don't pull it in though until we're ready to cut a 1.6. If you pull it in now we can't release a 1.5.x without cherrypicking.

sethkinast added a commit that referenced this pull request Mar 4, 2015
@sethkinast sethkinast merged commit 7e6c58a into LinkedInAttic:master Mar 4, 2015
@tlivings
Copy link

I love how this breaking change came out in a minor version bump.

@sethkinast
Copy link
Contributor

As has always been the case, Dust versioning follows different semantics than semver (this likely will change for Dust@3)

Minor versions of Dust can change or remove functionality after deprecating the functionality for one full minor release. Patch releases of Dust and helpers always maintain compatibility. We recommend using ~ versioning, not ^ versioning, for Dust's entry in your package.json.

These two helpers were present in helpers 1.4.0, deprecated (with messages) in 1.5.0, and removed in 1.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate and remove if helper
4 participants