Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hdiutil): fixed detach error check #190

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Conversation

blyork
Copy link
Contributor

@blyork blyork commented Apr 20, 2020

Fix for issue #142
Added check for err.code
Added 5 attempts with backoff.

Added check for err.code
Added 5 attempts with backoff.
@alexpelan
Copy link

I'd be glad to lend a hand to get this merged and released

@LinusU
Copy link
Owner

LinusU commented Nov 20, 2020

@alexpelan have you tested this? ☺️ if anyone can confirm that it works that would be great

@alexpelan
Copy link

Yeah, I patched this on my machine and it's working fine, unblocked me. I haven't ever reached the attempts > 5 boundary where it terminates, but I've definitely seen the backoff and future attempts succeeding. It seems like it fails exactly once for me every time 🤷

@alexswilliams
Copy link

Can confirm this commit also solves the problem perfectly for me - exactly as alex said, seemed to retry once :)

@elliottkember
Copy link

elliottkember commented Dec 9, 2020

I just hit the ERR_ELECTRON_BUILDER_CANNOT_EXECUTE error referenced above in an OSX 11.0 GitHub action, and will try to replicate. But this looks like a good workaround - who has write access and could merge this in?

@jjcoffman
Copy link

Is there anyone with the powers to get this in and cut a new release?

@joanx
Copy link

joanx commented Jul 6, 2021

We're also seeing this issue, confirmed this fix works, and would love to expedite this however we can.

@LinusU LinusU merged commit c9689f6 into LinusU:master Jul 7, 2021
@LinusU
Copy link
Owner

LinusU commented Jul 7, 2021

@joanx thanks for confirming that the fix works 👍

Released as 🚢 0.6.1 / 2021-07-07

@dmahieuDos
Copy link

Sorry to reopen this, but there is still an issue in that patch.
I've got a French version of OsX and /Resource busy/.test(err.stderr) test fails because message is partially translated (hdiutil: couldn't unmount "disk9" - Ressource occupée\n).

hdiutil returns EBUSY (16) on "Resource busy", then don't think it's needed to add Ressource busy test (redundant with err.code === 16).

@pzhlkj6612
Copy link
Contributor

Hi, @dmahieuDos . Please see #200 and upvote it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants