Add support for creating APFS disk images #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusU
reviewed
Feb 1, 2023
LinusU
reviewed
Feb 1, 2023
LinusU
reviewed
Feb 2, 2023
Co-authored-by: Linus Unnebäck <linus@folkdatorn.se>
|
Thank you for your work on this! 🙏 |
|
Released as 🚢 0.6.6 / 2023-02-03 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for creating APFS disk images which require macOS 10.13 or newer.
I tested this change locally with appdmg and verified generating both HFS+ and APFS disk images still work. I slightly changed the attach code to specify the mountpoint instead of fetching it from stdout for this change.
The use case is not wanting to support older OS systems for app disk images and not wanting to use HFS+, which while testing I've seen have worse performance for extraction*. Simply put, APFS is a more modern filesystem.
(*tested on macOS 13.0.1 with an app like VLC.app 3.0.18 (arm64; ~134 MB) under heavier compression using ULMO or UDBZ with Finder** and have seen ~2x performance difference; e.g. 3-4 sec vs 6-8 sec)
(**hdiutil is not measured because its disk image mounting implementation is slower as of current writing and doesn't well model a user using the dmg)