Fix module 'locale' has no attribute 'format' #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following error on python 3.12:
Traceback (most recent call last):
File "/usr/lib/python3.12/site-packages/qtvcp/widgets/origin_offsetview.py",
line 383, in periodic_check
self.reload_offsets()
File "/usr/lib/python3.12/site-packages/qtvcp/widgets/origin_offsetview.py",
line 270, in reload_offsets
degree_tmpl = "%{}.2f".format(len(locale.format(tmpl, 0)))
^^^^^^^^^^^^^
AttributeError: module 'locale' has no attribute 'format'. Did you mean: '_format'?
See also: python/cpython#94226
Signed-off-by: Damian Wrobel <dwrobel.contractor@libertyglobal.com>
|
Looks good to me. Should better go into 2.9 I think. |
|
I think locale is an artifact from converting from gladevcp anyways. Will back port/remove if required later. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error on python 3.12:
Traceback (most recent call last):
File "/usr/lib/python3.12/site-packages/qtvcp/widgets/origin_offsetview.py",
line 383, in periodic_check
self.reload_offsets()
File "/usr/lib/python3.12/site-packages/qtvcp/widgets/origin_offsetview.py",
line 270, in reload_offsets
degree_tmpl = "%{}.2f".format(len(locale.format(tmpl, 0)))
^^^^^^^^^^^^^
AttributeError: module 'locale' has no attribute 'format'. Did you mean: '_format'?
See also: python/cpython#94226