Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1846 - Add compartment variants to generated swagger/openapi #2192

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

tbieste
Copy link
Contributor

@tbieste tbieste commented Apr 1, 2021

Issue #1846 - Add compartment variants to generated swagger/openapi

Signed-off-by: Troy Biesterfeld tbieste@us.ibm.com

@tbieste tbieste requested a review from lmsurpre April 1, 2021 18:26
@tbieste tbieste marked this pull request as ready for review April 1, 2021 18:26
@tbieste tbieste marked this pull request as draft April 1, 2021 21:57
Signed-off-by: Troy Biesterfeld <tbieste@us.ibm.com>
@tbieste tbieste force-pushed the tbieste-issue-1846 branch from 36f58ea to 513b17d Compare April 2, 2021 00:01
@tbieste tbieste self-assigned this Apr 2, 2021
@tbieste tbieste requested review from lmsurpre and prb112 and removed request for lmsurpre April 2, 2021 13:16
@tbieste tbieste marked this pull request as ready for review April 2, 2021 13:16
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My biggest concern with this one is that it makes the all-in-one openapi a lot longer. Did you happen to try loading it from the liberty openapi ui?

@lmsurpre lmsurpre self-requested a review April 3, 2021 21:23
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbieste
Copy link
Contributor Author

tbieste commented Apr 5, 2021

My biggest concern with this one is that it makes the all-in-one openapi a lot longer. Did you happen to try loading it from the liberty openapi ui?

Yes, I did load it in the openapi ui.

@lmsurpre lmsurpre merged commit 81c6aa5 into main Apr 5, 2021
@lmsurpre lmsurpre deleted the tbieste-issue-1846 branch April 5, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants