Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to rename test suite and case #550

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

LinuxSuRen
Copy link
Owner

@LinuxSuRen LinuxSuRen commented Oct 20, 2024

We highly recommend you read the contributor's documentation before starting the review process especially since this is your first contribution to this project.

It was updated on 2024/5/27

What type of PR is this?

What this PR does / why we need it:
image
image

Which issue(s) this PR fixes:

Fixes #

@LinuxSuRen LinuxSuRen added the enhancement New feature or request label Oct 20, 2024
Copy link

github-actions bot commented Oct 20, 2024

There are 1 test cases, failed count 0:

Name Average Max Min Count Error
10.392723ms 12.067003ms 9.182482ms 3 0

Reported by api-testing.

@LinuxSuRen LinuxSuRen added the ui label Oct 20, 2024
Copy link

codacy-production bot commented Oct 20, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.31% (target: -1.00%) 15.56% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (72c53c2) 18174 7497 41.25%
Head commit (e74af38) 18833 (+659) 7711 (+214) 40.94% (-0.31%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#550) 392 61 15.56%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@yuluo-yx yuluo-yx self-assigned this Oct 21, 2024
Copy link
Collaborator

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LinuxSuRen
Copy link
Owner Author

The e2e was failed. I didn't figure out the reason yet.

@yuluo-yx
Copy link
Collaborator

testing-1  | POST http://localhost:8080/api/v1/suites error: Case: createSuite. error: error is: case: createSuite, expect 200, actual 503. body: {"code":14,"message":"connection error: desc = \"transport: Error while dialing: dial unix /root/.config/atest/atest-store-etcd.sock: connect: no such file or directory\"","details":[]}
testing-1  | Consumed: 3.009963309s
testing-1  | Error: failed to run 'createSuite', error is: case: createSuite, expect 200, actual 503

may be the problem here?

@LinuxSuRen
Copy link
Owner Author

Yes, I don't konw why the etcd extension is not ready.

Copy link

@LinuxSuRen
Copy link
Owner Author

may be the problem here?

hi @yuluo-yx I fixed it. Actually, the e2e helped me find the potential issues.

See also https://github.com/LinuxSuRen/api-testing/pull/550/files#diff-79261c1539975386167acc933dd926eab625c8571f084f71697e9f2e94bc7222R136

The tests failed due to incorrect lock usage. The wrong usage:

	s.lock.Lock()
        defer s.lock.Unlock()
	s.filesNeedToBeRemoved = append(s.filesNeedToBeRemoved, socketFile)
	s.extStatusMap[pluginName] = true

the correct one:

	s.lock.Lock()
	s.filesNeedToBeRemoved = append(s.filesNeedToBeRemoved, socketFile)
	s.extStatusMap[pluginName] = true
	s.lock.Unlock()

@LinuxSuRen LinuxSuRen merged commit 7d9a97f into master Oct 25, 2024
16 of 18 checks passed
@LinuxSuRen LinuxSuRen deleted the feat/rename-suite branch October 25, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants