Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export @Deprecated annotations on language elements #107

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

enikao
Copy link
Contributor

@enikao enikao commented Oct 14, 2024

implements #104

@enikao enikao requested a review from dslmeinte October 14, 2024 16:06
Copy link

github-actions bot commented Oct 14, 2024

Test Results

807 tests  +3   807 ✅ +3   12s ⏱️ -1s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 09964a3. ± Comparison against base commit c56025e.

♻️ This comment has been updated with latest results.

@dslmeinte
Copy link
Contributor

W.r.t. the LionCoreConstants.listMpsM2Annotations method: these are effectively the “special” annotations, but can we then name this method to reflect that?

@enikao
Copy link
Contributor Author

enikao commented Oct 14, 2024

W.r.t. the LionCoreConstants.listMpsM2Annotations method: these are effectively the “special” annotations, but can we then name this method to reflect that?

There are also methods listMpsM2AnnotationProperties() and listMpsM1AnnotationProperties(), so we'd need to keep them separate somehow. I'd rather like to change the term special at the other places, but couldn't come up with a better one.

@dslmeinte
Copy link
Contributor

W.r.t. the LionCoreConstants.listMpsM2Annotations method: these are effectively the “special” annotations, but can we then name this method to reflect that?

There are also methods listMpsM2AnnotationProperties() and listMpsM1AnnotationProperties(), so we'd need to keep them separate somehow. I'd rather like to change the term special at the other places, but couldn't come up with a better one.

Ha, figured that might've been the reason. We'll think of a better name at some point.

@enikao enikao merged commit a4b5e21 into mps2021.1 Oct 15, 2024
2 checks passed
@enikao enikao deleted the niko/export-deprecated branch October 15, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants