Fix PhpArrayDumper notice and PHP 5.3 compatibility #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh wow, when would that not be an object? |
|
It should be possible to unit test this? Could we setup a scenario for that? |
|
Actually, there's nothing to test because: Always returns an array, see: https://github.com/LionsAd/service_container/blob/7.x-1.x/lib/Drupal/Core/DependencyInjection/Dumper/PhpArrayDumper.php#L234 |
added 4 commits
June 18, 2015 00:14
drupol
changed the title
| $dump = unserialize($this->dumper->dump()); | ||
|
|
||
| $this->assertTrue(is_array($dump)); | ||
| $this->assertEquals($dump['services']['bar'], 'foo'); |
There was a problem hiding this comment.
Hm, but that should not be true.
It should actually be an array with [ 'alias': 'foo' ] set ...
Why do we need to change that?
drupol
added a commit
that referenced
this pull request
Jun 18, 2015
Fix PhpArrayDumper notice and PHP 5.3 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.