-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Miscellaneous.less
into several files
#4075
Conversation
It potentially can if two selectors have the same specificity |
so it is processed after DivTable.less since it uses them
so it is processed after DIvTables.less
did some 2 renames to account for it, should be all fine now |
There should realistically not be any cross-interaction between different sections of the Misc file, so splitting these into their own files will be fine in that regard. However, ResourceLoaderArticles and I'm not a massive fan of just merging and fixing if stuff breaks after the fact as we might not stumble upon issues until months down the line. One solution could be to name all the files Another solution (cc @FO-nTTaX), would be to add another (optional?) key to the database such as I don't mind investing some time into adding priority stuff into the extension if it's worthwhile. Don't have a mediawiki setup to test it on however, so would need testing by someone with a dev wiki. |
Adding a priority field to ResourceLoaderArticle could be done, making it optional would be weird though. I'd be more than happy to code review and test any changes there. |
Now that RLA has priority support, f30eef0 isn't strictly needed, but do we want to keep the files organized like that still or nah? |
nah I think, miscellaneous is not a category enough :D |
lmk if the PR is okay, so i can do the adjusts on commons (creating the new files & adjusting ressource loader) before merge |
DO NOT MERGE
to do
resolves #3765
Summary
Miscellaneous.less
currently has 5534 linesthis PR extracts styles from it into sep. files. and reduces the number of lines in
Miscellaneous.less
to 2782Please note this only extracts from an existing file into several files, it does not do any actual changes to the styles at all.
How did you test this change?
on darkrais dev wiki