This repository has been archived by the owner on Jan 14, 2022. It is now read-only.
Improve all transactions tab - Closes #591 #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalTuleja
previously requested changes
May 2, 2018
Undo the LessMoreByTimestamp implementation and use the new 'senderIdOrRecipientId' core filter instead
lsilvs
force-pushed
the
591-improve-all-transactions-request
branch
from
ab68a68
to
98b9cc6
Compare
MichalTuleja
approved these changes
May 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
All Transactions tab was relying on transaction timestamp to retrieve all transactions of an address. Last core release implemented a way to retrieve all transactions for a particular address which is cleaner and more efficient.
How did I fix it?
I've reverted the
LessMoreByTimestampimplementation and usedsenderIdOrRecipientIdfilter insteadHow to test it?
Access an address page and load More/Less transactions on All Transactions tab
Review checklist