This repository has been archived by the owner on Apr 15, 2019. It is now read-only.
Write unit tests for electron code - Closes #900 #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginacontrino
force-pushed
the
900-electron-tests
branch
4 times, most recently
from
95ea88d
to
81b094d
Compare
added 7 commits
November 14, 2017 17:03
ginacontrino
force-pushed
the
900-electron-tests
branch
from
5d15c4a
to
46e8709
Compare
yasharAyari
suggested changes
Nov 14, 2017
app/src/menu.js
Outdated
| }; | ||
|
|
||
| module.exports = menu; |
There was a problem hiding this comment.
Please use es6 export instead of 'module.export'
ginacontrino
force-pushed
the
900-electron-tests
branch
from
46e8709
to
bd483d1
Compare
yasharAyari
approved these changes
Nov 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
We had no tests for the electron code
How did I fix it?
Refactored and added unit ests
How to test it?
Review checklist