Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Add eslint no-exclusive-tests rule - Closes #893 #993

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Add eslint no-exclusive-tests rule - Closes #893 #993

merged 2 commits into from
Nov 21, 2017

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Nov 20, 2017 •
edited
Loading

What was the problem?

We could forget .only in our tests

How did I fix it?

Add eslint no-exclusive-tests rule

How to test it?

Use .only and run npm run eslint

Review checklist

@slaweet slaweet self-assigned this Nov 20, 2017
@slaweet slaweet requested a review from reyraa November 20, 2017 17:03
@slaweet slaweet changed the base branch from development to 1.3.0 November 20, 2017 17:03
@slaweet slaweet merged commit 260d1a4 into 1.3.0 Nov 21, 2017
@slaweet slaweet deleted the 893-add-eslint-no-exclusive-tests branch November 21, 2017 08:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reyraa reyraa reyraa approved these changes

Assignees

@slaweet slaweet

Labels
✅ ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slaweet @reyraa