Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE_REQUEST] allow toggle fullscreen for iframes in workspace view #524

Closed
Byolock opened this issue Mar 2, 2022 · 2 comments
Closed

[FEATURE_REQUEST] allow toggle fullscreen for iframes in workspace view #524

Byolock opened this issue Mar 2, 2022 · 2 comments
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change

Comments

@Byolock
Copy link

Byolock commented Mar 2, 2022

Is your feature request related to a problem? If so, please describe.

Toggle fullscreen buttons currently don't work in workspace view because iframes need to have
<iframe allow="fullscreen"></iframe> set.

Describe the solution you'd like

Set allow="fullscreen" globally for dashy, or if there are any drawbacks that im not aware of providing it as an optional setting would be great

Priority

Medium (Would be very useful)

Is this something you would be keen to implement

No
@Byolock Byolock added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Mar 2, 2022
@Lissy93
Copy link
Owner

Lissy93 commented Mar 2, 2022

Sure, good idea - will look into this and hopefully get a PR submitted this week :)

And thank you so much for the sponsorship 💖

Lissy93 added a commit that referenced this issue Mar 27, 2022
@Lissy93
⚡ Allows full-screen for iframes (#524)
e616d90
@Lissy93 Lissy93 mentioned this issue Mar 27, 2022
Merged
6 tasks
@Lissy93
Copy link
Owner

Lissy93 commented Mar 28, 2022

Apologies again for the delay, have had a lot on. This has now been implemented in #557 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lissy93 @Byolock