-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drone io widget #1037
Drone io widget #1037
Conversation
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Changes preview: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small thing left to do, the widget needs to be registered.
If you add: 'drone-io': 'DroneIo',
into WidgetBase.vue
(the first part is the widgets ID, and is used for type: widget-name
in the config, and the second part needs to match the filename)
After that, and the few minor changes in the docs, it all looks good to me :)
I don't have access to a Drone instance to hand to test the functionality, but your code looks good, so I trust it works if you've tested it :)
There's also 2 security hotspots raised by SonarCloud (here), both relate to piping the response strait into the href attribute of the link. But if we can trust the response from the API, then I believe in this instance those should be fine. That's the reason for the failing check. |
Drone CI is the current term used for the Build System (or just Drone, which is a bit to unspecific for identification)
What would be the alternative way to do it? The other points I already changed. Still I'm improving the display of the information a bit. Also renamed it from drone.io to Drone CI (Where Drone is the current name but it is too vague imho). |
@Lissy93 anything missing here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sorry for the delay, this totally slipped my mind 😬
Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)
Category: Feature
Overview
Added Widget for Drone.io build status
New Vars
Configuration for the plugin:
host
string
apiKey
string
limit
integer
Screenshot (if applicable)
Code Quality Checklist (Please complete)