Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing localization for every element on Dashy #1041

Merged
merged 4 commits into from
Feb 19, 2023
Merged

Increasing localization for every element on Dashy #1041

merged 4 commits into from
Feb 19, 2023

Conversation

DimitriDR
Copy link
Contributor

@DimitriDR DimitriDR commented Jan 7, 2023

DimitriDR 🌐 Language Update Medium DimitriDR /master → Lissy93/dashy Commits: 4 | Files Changed: 8 | Additions: 120 Unchecked Tasks

Category:

One of: Feature / Translation

Overview

I've seen that some elements are not translatable. Therefore, for the sake of accessibility, I'll try to map Vue components and localization files to allow people to translate Dashy. This is a draft, I'll contribute to it until every element is done.

New Vars

New strings in en.json file (and fr.json as my mother language is French 🥖 ). I tried to follow the current naming convention.

Screenshot (if applicable)
Footer done (It was initially just to test if I could be able to make it)

In English, no change (just one bug):
Screenshot 2023-01-07 at 17-17-15 HomeLab Dashboard

In French, It is (almost) correctly translated 😄
Screenshot 2023-01-07 at 17-17-30 HomeLab Dashboard

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

Signed-off-by: DimitriDR <dimitridroeck@gmail.com>
@netlify
Copy link

netlify bot commented Jan 7, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit f214667
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63b9f22f49c28000090bb701
😎 Deploy Preview https://deploy-preview-1041--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jan 7, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@DimitriDR DimitriDR mentioned this pull request Jan 7, 2023
5 tasks
@liss-bot
Copy link
Collaborator

liss-bot commented Feb 7, 2023

This PR is stale because it has been open 6 weeks with no activity. Either remove the stale label or comment below with a short update, otherwise this PR will be closed in 5 days.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Feb 7, 2023
@DimitriDR
Copy link
Contributor Author

Ready to review. It's already a good start.

@DimitriDR DimitriDR marked this pull request as ready for review February 7, 2023 13:55
@DimitriDR DimitriDR requested a review from Lissy93 as a code owner February 7, 2023 13:56
@liss-bot liss-bot removed the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Feb 7, 2023
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks!

@Lissy93 Lissy93 merged commit 08e5e5b into Lissy93:master Feb 19, 2023
@Lissy93 Lissy93 added the 🌐 Language [PR] Adds a new language translation label Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 Language [PR] Adds a new language translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants