Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XKCD: Use tooltip for alt text #1043

Merged
merged 1 commit into from
Jan 7, 2023
Merged

Conversation

m42e
Copy link
Contributor

@m42e m42e commented Jan 7, 2023

m42e Medium m42e /xkcd-show-alt → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 11 Label

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category: Bufix

Overview
The alt text is not shown while hovering. I added a tooltip, so the alt text could be revealed easily.

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors

@m42e m42e requested a review from Lissy93 as a code owner January 7, 2023 18:30
@netlify
Copy link

netlify bot commented Jan 7, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit d4528a1
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63b9ba40c3156500080c4fed
😎 Deploy Preview https://deploy-preview-1043--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jan 7, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lissy93 Lissy93 merged commit a5f3c20 into Lissy93:master Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants