Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix health-check when using SSL #1076

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Fix health-check when using SSL #1076

merged 2 commits into from
Jan 21, 2023

Conversation

rtm516
Copy link
Contributor

@rtm516 rtm516 commented Jan 21, 2023

rtm516 Medium rtm516 /master → Lissy93/dashy Commits: 2 | Files Changed: 2 | Additions: 7 Label

Category: Bugfix and Feature

Overview
Fixes health-check issues when using SSL or a slower server that takes more than 2s to check

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors

@rtm516 rtm516 requested a review from Lissy93 as a code owner January 21, 2023 16:40
@netlify
Copy link

netlify bot commented Jan 21, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 3c5177d
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63cc1565d276e0000bfda216
😎 Deploy Preview https://deploy-preview-1076--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jan 21, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants