Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Import manifest in index.html #1219

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Jun 10, 2023

Quick Lissy93 /FEAT/import-manifest → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 1 Label Unchecked Tasks Powered by Pull Request Badge

Category:
Fix/ update

Overview
Imports the PWA manifest into index.html, some newer browsers don't automatically pick it up

Issue Number #1215

New Vars N/A

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Jun 10, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 81c6129
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/6484bd55178e8a0008b3ebdd
😎 Deploy Preview https://deploy-preview-1219--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jun 10, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@Lissy93 Lissy93 merged commit ece9548 into master Jun 10, 2023
@Lissy93 Lissy93 deleted the FEAT/import-manifest branch June 10, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant