Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(weather forecast): updated widget #1369

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Conversation

sachahjkl
Copy link
Contributor

@sachahjkl sachahjkl commented Oct 28, 2023

sachahjkl Quick sachahjkl /fix/weather → Lissy93/dashy Commits: 1 | Files Changed: 2 | Additions: 0 Unchecked Tasks Powered by Pull Request Badge

Updated the widget and api route to work with the new (why ?) OpenWeater response format.

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:
Bugfix

Overview
Updated the widget and api route to work with the new (why ?) OpenWeater response format.

Issue Number #1321

Screenshot

image

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

Updated the widget and api route to work with the new (why ?) OpenWeater response format.
@sachahjkl sachahjkl requested a review from Lissy93 as a code owner October 28, 2023 11:57
@vercel
Copy link

vercel bot commented Oct 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2023 11:58am

@netlify
Copy link

netlify bot commented Oct 28, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 5adf9ef
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/653cf72e5ed8e200088f68ff
😎 Deploy Preview https://deploy-preview-1369--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@viezly
Copy link

viezly bot commented Oct 28, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@sachahjkl
Copy link
Contributor Author

For issue #1321

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks @sachahjkl 🙌

@Lissy93 Lissy93 merged commit 56bd835 into Lissy93:master Oct 28, 2023
10 checks passed
@sachahjkl sachahjkl deleted the fix/weather branch October 28, 2023 22:29
@maxpoullain
Copy link

Hi there! 👋

@Lissy93 Any idea when will you tag and build a new public release (and Docker image) to include this fix ?
Looks like last month release 2.1.1 doesn't really match master branch

@sachahjkl Thanks for the fix as well 🙏

Thanks!

@Lissy93
Copy link
Owner

Lissy93 commented Feb 27, 2024

Yes, stay tuned, later this week. Once FEAT/2.1.2_dependency-updates-n-fixes you'll have a new tagged update in DockerHub.
Apologies that it's been so long

@liss-bot
Copy link
Collaborator

liss-bot commented Mar 3, 2024

The fix for this issue has now been released in 2.1.2 ✨

If you haven't done so already, please update your instance to 2.1.2 or later. See 2.1.2 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants