Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Opening methods, and context menu #62

Merged
merged 13 commits into from
Jun 25, 2021
Merged

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Jun 25, 2021

Lissy93 /FEATURE_context-menu → Lissy93/dashy Commits: 13 | Files Changed: 16 | Additions: 323 Powered by Pull Request Badge

Category: Feature

Overview

Implemented a right-click context menu for items, enabling the user to choose an opening method on the fly.

Aim: It's not always clear to the user that there are multiple options for opening items. In this task I am going to create a simple context menu, visible when the user right-clicks (or long-press if on mobile) a given item. This will also lay the ground work for a future feature, where I add some edit functionality to items, as the context menu will contain this an Open Edit button.

Issue Number N/A

New Vars

  • appConfig.disableContextMenu - A boolean value, defaulting to false giving the user the option to disable the custom context menus
  • Also added a new value to the Enum for target called workspace, to open items in the work space by default

Screenshot

This is the context menu, it is visible when the user right-clicks on an item.
dashy-context-menu-2

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance

@netlify
Copy link

netlify bot commented Jun 25, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 407c4fa

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/60d5df3b1b7fc30008b90fea

😎 Browse the preview: https://deploy-preview-62--dashy-dev.netlify.app/

@Lissy93 Lissy93 merged commit 11e0abf into master Jun 25, 2021
@Lissy93 Lissy93 deleted the FEATURE_context-menu branch June 25, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant