Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TFL Status Widget to include Elizabeth Line/Tram/DLR/Overground #766

Merged
merged 1 commit into from
Jun 26, 2022
Merged

Update TFL Status Widget to include Elizabeth Line/Tram/DLR/Overground #766

merged 1 commit into from
Jun 26, 2022

Conversation

dougaldhub
Copy link

@dougaldhub dougaldhub commented Jun 26, 2022

dougaldhub Quick dougaldhub /FEATURE/improve-tfl-widget → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Label Unchecked Tasks

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:

Feature

Overview

This PR will update the tflStatus API endpoint to have the widget support all modes of transport from the "normal" TFL status updates page here: https://tfl.gov.uk/tube-dlr-overground/status/. Previously only Tube lines were included which excluded the newly opened Elizabeth Line as well as the Trams, DLR and Overground services.

This will help me out greatly as I use Dashy at work daily and now travel via the newly-opened Elizabeth line instead of my old Tube line.

Screenshot (if applicable)

image

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@dougaldhub dougaldhub requested a review from Lissy93 as a code owner June 26, 2022 16:25
@netlify
Copy link

netlify bot commented Jun 26, 2022

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 4b65fed
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/62b888904b71b800083e9f3a
😎 Deploy Preview https://deploy-preview-766--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Jun 26, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

I hope it won't be the bearer of bad news with all the strikes on at the moment 😅

@Lissy93 Lissy93 merged commit b876fa1 into Lissy93:master Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants