Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add parameter name to OverworldBiomeBuilder _addUndergroundBiome and _addSurfaceBiome #1423

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

killcerr
Copy link
Contributor

@killcerr killcerr commented Jan 6, 2024

What does this PR do?

add parameter name to OverworldBiomeBuilder _addUndergroundBiome and _addSurfaceBiome

Which issues does this PR resolve?

Checklist before merging

Thank you for your contribution to the repository.
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • Your code follows the code style of this repository (see the wiki)
  • You have tested all functions
  • You have not used code without license
  • You have added statement for third-party code

@KawaiiNahida
Copy link
Member

How do you know the parameter names of this function? Have they been validated?

@killcerr killcerr closed this Jan 6, 2024
@KawaiiNahida KawaiiNahida reopened this Jan 6, 2024
@KawaiiNahida
Copy link
Member

the parameter names seems to be correct. Thank you for your Pull Request.

@KawaiiNahida KawaiiNahida merged commit b55f217 into LiteLDev:develop Jan 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants