Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MaterialType.h #1529

Merged
merged 2 commits into from
May 8, 2024
Merged

Update MaterialType.h #1529

merged 2 commits into from
May 8, 2024

Conversation

wu-vincent
Copy link
Contributor

What does this PR do?

Update the enum values for MaterialType

Which issues does this PR resolve?

The MaterialType enum values are outdated. A new enum Shulker was added before SurfaceTypeTotal. See StringFromMaterialType for reference.

Checklist before merging

Thank you for your contribution to the repository.
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • Your code follows the code style of this repository (see the wiki)
  • You have tested all functions
  • You have not used code without license
  • You have added statement for third-party code

wu-vincent and others added 2 commits May 8, 2024 00:33
The MaterialType enum is outdated. See `StringFromMaterialType` for reference.
Copy link
Member

@twoone-3 twoone-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem, Man!

@ShrBox ShrBox merged commit 2fdbcff into LiteLDev:develop May 8, 2024
5 checks passed
@wu-vincent wu-vincent deleted the patch-1 branch May 8, 2024 08:45
ShrBox pushed a commit that referenced this pull request May 31, 2024
The MaterialType enum is outdated. See `StringFromMaterialType` for reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants